Skip to content

Update CI to use pnpm v7 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

theory-in-progress
Copy link
Contributor

@theory-in-progress theory-in-progress commented Apr 16, 2023

Description

Fix #

  • Fixed pnpm version to 7 so that ci is not breaking.
  • Cannot perform a frozen installation because the lockfile needs updates
  • Refer pnpm issue #40
  • Have to upgrade pnpm to version 8 and then fix lock files, for now the installation installs pnpm v7

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

- Fixed pnpm version to 7 so that ci is not breaking
@netlify
Copy link

netlify bot commented Apr 16, 2023

Deploy Preview for code-generator failed.

Name Link
🔨 Latest commit 4f12f3a
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/643bc99fe3536100082fba3d

@vfdev-5
Copy link
Member

vfdev-5 commented Apr 17, 2023

Thanks for the fix @theory-in-progress , looks like the CI is fixed for the previous bug with pnpm and just failing with segmentation templates as described in #232

Please make the description more detailed about what has changed and why. Also please change the title "Fix ci2" into a concise sentence describing the content. Thanks !

@theory-in-progress theory-in-progress changed the title Fix ci2 Update CI to use pnpm v7 Apr 18, 2023
@vfdev-5 vfdev-5 merged commit 8168e8b into pytorch-ignite:main Apr 18, 2023
@theory-in-progress theory-in-progress deleted the Fix-CI2 branch June 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants